OneSizeFitsQuorum commented on code in PR #1298:
URL: https://github.com/apache/ratis/pull/1298#discussion_r2415362289
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -409,7 +409,7 @@ boolean start() throws IOException {
startAsPeer(RaftPeerRole.LISTENER);
} else {
LOG.info("{}: start with initializing state, conf={}", getMemberId(),
conf);
- setRole(RaftPeerRole.FOLLOWER, "start");
Review Comment:
Do we need to use LeaderElection.Result.NOT_IN_CONF?
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -409,7 +409,7 @@ boolean start() throws IOException {
startAsPeer(RaftPeerRole.LISTENER);
} else {
LOG.info("{}: start with initializing state, conf={}", getMemberId(),
conf);
- setRole(RaftPeerRole.FOLLOWER, "start");
Review Comment:
Do we need to use `LeaderElection.Result.NOT_IN_CONF`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
