ivandika3 commented on PR #1340: URL: https://github.com/apache/ratis/pull/1340#issuecomment-3858235230
@szetszwo Thanks for the review. > Instead of trigger a heartbeat, how about adding a CommitInfoProto list to ReadIndexReplyProto. Then, the follower can update the commit indices with the reply. As specified by the Raft paper, Raft follower updates its commitIndex through when handling `AppendEntries` from a valid leader. Therefore, I'm not sure whether updating the follower's commitIndex can be done out-of-band (i.e. using `CommitInfoProto` in another ReadIndex channel). Especially there were previous issues where there were race condition issues on heartbeat and append log (e.g. RATIS-2234, RATIS-2235, RATIS-2242, etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
