szetszwo commented on code in PR #1341:
URL: https://github.com/apache/ratis/pull/1341#discussion_r2778212167
##########
ratis-proto/src/main/proto/Raft.proto:
##########
@@ -121,6 +121,7 @@ message RaftRpcRequestProto {
uint64 timeoutMs = 13;
RoutingTableProto routingTable = 14;
SlidingWindowEntry slidingWindowEntry = 15;
+ SpanContextProto spanContext = 16;
Review Comment:
We should not use 16; see
https://protobuf.dev/programming-guides/proto3/#assigning :
> You should use the field numbers 1 through 15 for the most-frequently-set
fields. Lower field number values take less space in the wire format. ...
Let's use 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
