[
https://issues.apache.org/jira/browse/RATIS-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze resolved RATIS-2407.
-------------------------------
Fix Version/s: 3.3.0
Resolution: Fixed
The pull request is now merged. Thanks, [~slfan1989]!
> Missing return statement after stream closed check in
> OrderedRequestStreamObserver
> ----------------------------------------------------------------------------------
>
> Key: RATIS-2407
> URL: https://issues.apache.org/jira/browse/RATIS-2407
> Project: Ratis
> Issue Type: Bug
> Components: gRPC
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Fix For: 3.3.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> After detecting the stream is closed and reporting the error, the method
> should return immediately to avoid:
> - Creating unnecessary objects
> - Modifying state of a closed stream
> - Potential memory leaks and state inconsistencies
>
> Add a `return` statement after the `responseError()` call at line 340.
>
> The same method already has correct error handling for group mismatch at line
> ~354, which includes a `return` statement after calling `responseError()`.
> The stream-closed check should follow the same pattern.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
