slfan1989 opened a new pull request, #1359:
URL: https://github.com/apache/ratis/pull/1359
## What changes were proposed in this pull request?
This PR reduces test log noise by adjusting logging levels and making
logging more selective:
- `NettyRpcProxy.java`: Changed `LoggingHandler` from `LogLevel.WARN` to
`LogLevel.DEBUG` with explanatory comment, since it emits all Netty pipeline
events at the chosen level.
- `TestRaftAsyncWithNetty.java`: Override base class DEBUG settings by
raising `RaftServer.Division` and `RaftClient` log levels back to INFO to
reduce verbose test output.
- Modified `testWithLoad` Timer to only print cluster/client state when no
progress is detected (moved logs into the "no progress" branch)
- Before changes:
- Timer prints unconditionally every `10` seconds (starting after 5
seconds)
- Log frequency = 1 time / 10 seconds = 6 times / minute
- After changes:
- Only prints when `no progress` is detected
- `No progress` definition: lastStep remains unchanged between
consecutive Timer checks (10-second interval)
- lastStep update condition: cumulative progress delta ≥ 50 ×
numClients
- Trigger condition: cumulative progress delta < 50 × numClients
within 10 seconds
- Converted all string concatenation logging to placeholder style (`{}`) for
better performance and consistency
## What is the link to the Apache JIRA
JIRA: RATIS-2418. NettyClient LoggingHandler prints too many messages.
## How was this patch tested?
Existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
