adoroszlai opened a new pull request, #1360: URL: https://github.com/apache/ratis/pull/1360
## What changes were proposed in this pull request? `checkstyle.sh` reports violations in generated Java sources in `ratis-proto` if there is any other violation or compile error (which triggers the second run, including compilation): https://github.com/apache/ratis/blob/f9757f6298397c4e13783e97f6bf5718839e0898/dev-support/checks/checkstyle.sh#L29-L32 Steps to reproduce: ```bash echo ' ' >> ratis-tools/src/main/java/org/apache/ratis/tools/DefaultLogDump.java ./dev-support/checks/checkstyle.sh ``` This change makes checkstyle skip generated sources. It also removes unnecessary plugin definition, which was probably intended to skip checkstyle in `ratis-proto`, but apparently it does not. https://issues.apache.org/jira/browse/RATIS-2419 ## How was this patch tested? Before: ```bash $ ./dev-support/checks/checkstyle.sh >& /dev/null $ cat target/checkstyle/failures 4654 ``` After: ```bash $ ./dev-support/checks/checkstyle.sh >& /dev/null $ cat target/checkstyle/failures 1 $ cat target/checkstyle/summary.txt ratis-tools/src/main/java/org/apache/ratis/tools/DefaultLogDump.java 43: Line has trailing spaces. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
