OneSizeFitsQuorum commented on code in PR #1376:
URL: https://github.com/apache/ratis/pull/1376#discussion_r2934789458
##########
dev-support/make_rc.sh:
##########
@@ -96,10 +96,6 @@ mvnFun() {
git reset --hard
git clean -fdx
mvnFun versions:set -DnewVersion="$RATISVERSION" -DprocessAllModules
- if ! git diff --name-only | grep -q ratis-bom/pom.xml; then
- echo 'ratis-bom not updated by `mvn versions:set`' >&2
- exit 1
- fi
git commit --allow-empty -a -m "Change version for the version $RATISVERSION
$RC"
Review Comment:
I guess it’s fine either way, but it’s definitely clearer with it.
Otherwise, the latest commits might look like they're still on RC1, and we
won't know if that's a mistake or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
