szetszwo commented on code in PR #1379:
URL: https://github.com/apache/ratis/pull/1379#discussion_r2942256201
##########
ratis-docs/src/site/markdown/membership-change.md:
##########
@@ -39,11 +39,11 @@ Be careful to keep both separate majorities online!
To add a new node (e.g., `N3`) to an existing group (e.g., `N0`, `N1`, `N2`),
follow these steps:
-1. Start the new peer `N3` with **EMPTY** group.
+1. Start the new peer `N3` with the existing groupID but provide an empty list
of peers.
Review Comment:
Let's use "the existing groupId and an empty list of peers."
##########
ratis-docs/src/site/markdown/membership-change.md:
##########
@@ -39,11 +39,11 @@ Be careful to keep both separate majorities online!
To add a new node (e.g., `N3`) to an existing group (e.g., `N0`, `N1`, `N2`),
follow these steps:
-1. Start the new peer `N3` with **EMPTY** group.
+1. Start the new peer `N3` with the existing groupID but provide an empty list
of peers.
```java
RaftServer N3 = RaftServer.newBuilder()
- .setGroup(RaftGroup.emptygroup())
+ .setGroup(RaftGroup.valueOf(groupId, List.of()))
Review Comment:
Please use standard Java API Collections.emptyList() and keep the
indentation.
```
.setGroup(RaftGroup.valueOf(groupId, Collections.emptyList()))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
