ivandika3 commented on PR #1438: URL: https://github.com/apache/ratis/pull/1438#issuecomment-4301401193
@szetszwo Thanks for the patch. LGTM +1. > Tried to set a special minIndex (e.g. Long.MAX_VALUE/MIN_VALUE) to staleRead but it became an incompatible change since users might also set it. Yes, we should not use `staleRead` since the behavior might be coupled with `StateMachine#queryStale` which can cause unpredictability. > Then, found that watch request passed a null message and users could not set it. So, we may send a watch request with a "DUMMY" message. The server can detect it and return immediately without leader check. This is a good workaround. > LinearizableReadTests can pass. Thanks, do you think we should include tests like `runTestFollowerLinearizableReadStaysOnFollower` in https://github.com/apache/ratis/pull/1433 to be more explicit? I'm OK if you choose to leave it be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
