szetszwo commented on code in PR #1445:
URL: https://github.com/apache/ratis/pull/1445#discussion_r3190290254
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcClientProtocolService.java:
##########
@@ -165,6 +165,10 @@ void closeAllExisting(RaftGroupId groupId) {
zeroCopyMetrics.addUnreleased("client_protocol",
zeroCopyRequestMarshaller::getUnclosedCount);
}
+ void close() {
+ zeroCopyRequestMarshaller.close();
Review Comment:
This is good catch! We never call zeroCopyRequestMarshaller.close() except
for tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
