szetszwo commented on code in PR #1444:
URL: https://github.com/apache/ratis/pull/1444#discussion_r3244182726
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -1146,7 +1145,8 @@ private CompletableFuture<RaftClientReply>
readAsync(RaftClientRequest request)
}
return replyFuture
- .thenCompose(readIndex -> getReadRequests().waitToAdvance(readIndex))
+ .thenCompose(readIndex ->
getState().getReadRequests().waitToAdvance(readIndex,
+
snapshotInstallationHandler::getInProgressInstallSnapshotReadException))
Review Comment:
@ivandika3 , That is a good point! Then, let's use your previous approach
then; see
https://issues.apache.org/jira/secure/attachment/13082234/1444_review2.patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
