szetszwo commented on code in PR #1466:
URL: https://github.com/apache/ratis/pull/1466#discussion_r3276156221
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/GrpcConfigKeys.java:
##########
@@ -155,6 +155,22 @@ static GrpcTlsConfig tlsConf(Parameters parameters) {
static void setTlsConf(Parameters parameters, GrpcTlsConfig conf) {
parameters.put(TLS_CONF_PARAMETER, conf, TLS_CONF_CLASS);
}
+
+ /**
+ * The number of worker threads for the gRPC client-side {@link
+ * org.apache.ratis.thirdparty.io.netty.channel.EventLoopGroup}.
+ * 0 (default) means use the gRPC default (i.e. {@code availableProcessors
* 2});
+ * a positive value caps the worker event-loop thread count.
+ */
+ String WORKER_EVENT_LOOP_THREADS_KEY = PREFIX +
".worker.event-loop.threads";
Review Comment:
In NettyConfigKeys, we have the following conf:
```
key: raft.netty.dataStream.client.use-epoll (boolean, default=true)
key: raft.netty.dataStream.client.worker-group.size (int, default=28)
```
Let's use similar conf for gRPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
