CRZbulabula commented on PR #1475: URL: https://github.com/apache/ratis/pull/1475#issuecomment-4585721927
Thanks for the review. I updated the PR to address the inline comments: * Removed the `LeaderStateImpl` change from this PR; this PR is test-only now. * Restored the kill-leader timing so leader restart is scheduled before client messages are sent. * Kept the async reply list cleanup and removed the redundant `allOf` join. * Joined restart futures before `cluster.printAllLogs()` without the try/finally restructuring. * Removed the redundant `toString()` calls in the election command test. * For kill-leader append tests, the final assertion now verifies the expected messages appear in order while tolerating an extra retry/failover state-machine entry. Local verification: `mvn -pl ratis-test -am -Dtest=TestLinearizableReadRepliedIndexWithGrpc,TestRaftAsyncWithGrpc#testBasicAppendEntriesAsyncKillLeader,TestElectionCommandIntegrationWithGrpc,TestRaftLogTruncateWithGrpc,TestRaftWithGrpc test` `mvn -pl ratis-test -am -Dtest=TestRaftReconfigurationWithSimulatedRpc#testKillLeaderDuringReconf test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
