HTHou commented on PR #1478: URL: https://github.com/apache/ratis/pull/1478#issuecomment-4696286438
Updated the PR to address the inline review comments: - Moved the OpenTelemetry-specific tracing classes under `org.apache.ratis.trace.opentelemetry`. - Removed `TraceProvider.isEnabled()` and switched `TraceUtils.isEnabled()` to check the provider type. - Changed OpenTelemetry provider initialization to throw `IllegalStateException` when tracing is enabled but OpenTelemetry is unavailable. - Added `Objects.requireNonNull(...)` for the global tracer, removed the one-use helper, and restored the `addListener` javadoc. Also rebased on the latest `master` and force-pushed the updated single-commit branch. Verified with: - `./mvnw -pl ratis-server -am -Dtest=RaftServerImplTracingTests -DfailIfNoTests=false test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
