[
https://issues.apache.org/jira/browse/RATIS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886773#comment-15886773
]
Jing Zhao commented on RATIS-31:
--------------------------------
Thanks for working on this, Nicholas! The patch looks good to me. Just several
minor comments:
# There is an extra line at the end of {{SupportedRpcType}}
# {{RaftUtils#getClass}} can utilize {{RaftProperties#getClassByName}}. Also it
can return {{sub.asSubClass(base)}}
> Support customized RPC types
> ----------------------------
>
> Key: RATIS-31
> URL: https://issues.apache.org/jira/browse/RATIS-31
> Project: Ratis
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: r31_20170227.patch
>
>
> This JIRA is to address [~jingzhao] comment in RATIS-28
> {quote}
> Maybe we should consider using RpcType as an internal util stuff instead of
> exposing it in public interfaces, considering most library users will have to
> integrate the Ratis library with their own RPC engine.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
