[ 
https://issues.apache.org/jira/browse/RATIS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated RATIS-52:
---------------------------
    Attachment: ratis-52-fix.patch

The bug was caused by the newly added methods in ReflectionUtils.java, and it's 
mainly because of the several varargs methods. I think for this patch we can do 
the code refactoring work only, i.e., only moving the existing 
reflection-related methods out of RaftUtils.java. And we can add new methods 
when they are used in the replicated map work.

> Refactor RaftUtils into different classes
> -----------------------------------------
>
>                 Key: RATIS-52
>                 URL: https://issues.apache.org/jira/browse/RATIS-52
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.1.0-alpha
>
>         Attachments: ratis-52-fix.patch, ratis-52_v1.patch, ratis-52_v2.patch
>
>
> Ideally we should not have a generic {{RaftUtils}} class. The code should be 
> broken up into at least: 
> {code}
> ReflectionUtils -> All reflection, construction, initialization logic 
> IOUtils -> Add buffer and IO logic 
> SystemUtils or PlatformUtils -> OS type detection, etc 
> Preconditions (or something like that) -> assertTrue, etc 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to