[
https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244522#comment-16244522
]
Jing Zhao commented on RATIS-77:
--------------------------------
It's because if the incoming request is a stream, we expect response for each
chunk so that we can detect failure earlier.
> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> ----------------------------------------------------------
>
> Key: RATIS-77
> URL: https://issues.apache.org/jira/browse/RATIS-77
> Project: Ratis
> Issue Type: Bug
> Reporter: kaiyangzhang
> Assignee: garvit
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
> ......
> ......
> //Executes a client-streaming call , return only one response.
> rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
> returns(ratis.common.InstallSnapshotReplyProto) {}
> .......
> .......
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
> ........
> ........
> @Override
> public StreamObserver<InstallSnapshotRequestProto> installSnapshot(
> StreamObserver<InstallSnapshotReplyProto> responseObserver) {
> return new StreamObserver<InstallSnapshotRequestProto>() {
> @Override
> public void onNext(InstallSnapshotRequestProto request) {
> try {
> //receive a client-streaming call, return a response stream
> //code and GRpc.proto inconsistent
> final InstallSnapshotReplyProto reply =
> server.installSnapshot(request);
> responseObserver.onNext(reply);
> } catch (Throwable e) {
> LOG.info("{} got exception when handling installSnapshot {}: {}",
> id, request.getServerRequest(), e);
> responseObserver.onError(RaftGrpcUtil.wrapException(e));
> }
> }
> ..........
> ..........
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
