[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263369#comment-16263369
]
Chen Liang commented on RATIS-141:
----------------------------------
Thanks [~szetszwo] for working on this! Had an offline discussion with
Nicholas. Seems that we may not really need to add this variable
{{asyncSeqNum}}. And just making {{callIdCounter}} non-static would do the same
job.
> In RaftClientProtocolService, the assumption of consecutive callId is invalid
> -----------------------------------------------------------------------------
>
> Key: RATIS-141
> URL: https://issues.apache.org/jira/browse/RATIS-141
> Project: Ratis
> Issue Type: Bug
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: r141_20171117.patch, r141_20171119b.patch,
> r141_20171120.patch
>
>
> {code}
> //RaftClientProtocolService.AppendRequestStreamObserver.onNext(..)
> // we assume the callId is consecutive for a stream RPC call
> final PendingAppend pendingForReply = pendingList.get(
> (int) (replySeq - headSeqNum));
> {code}
> Call id is used for different kinds of calls (e.g. getInfo) so that it may
> not be consecutive.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
