[ 
https://issues.apache.org/jira/browse/RATIS-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584622#comment-16584622
 ] 

ASF GitHub Bot commented on RATIS-272:
--------------------------------------

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/incubator-ratis/pull/4#discussion_r211064260
  
    --- Diff: 
ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogWriter.java 
---
    @@ -0,0 +1,43 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.ratis.logservice.api;
    +
    +import java.io.IOException;
    +import java.nio.ByteBuffer;
    +
    +/**
    + * Synchronous client interface to write to a LogStream.
    + */
    +public interface LogWriter extends AutoCloseable {
    +
    +  /**
    +   * Appends the given data as a record in the LogStream.
    +   *
    +   * @param data The record to append
    +   * @return The recordId for the record just written
    +   */
    +  long write(ByteBuffer data) throws IOException;
    +
    +  /**
    +   * Guarantees that all previous data appended by {@link 
#write(ByteBuffer)} are persisted
    +   * and durable in the LogStream.
    +   *
    +   * @return TODO Unknown?
    +   */
    --- End diff --
    
    Return last recordId committed.


> Design ideal API
> ----------------
>
>                 Key: RATIS-272
>                 URL: https://issues.apache.org/jira/browse/RATIS-272
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: LogService
>            Reporter: Josh Elser
>            Priority: Major
>
> With influence from Apache DistributedLog, Kafka, and BookKeeper, design an 
> API that balances the ideal notion of what a distribute log system should 
> look like, but also considers the needs of HBase to replace a WAL.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to