[ https://issues.apache.org/jira/browse/RATIS-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599168#comment-16599168 ]
ASF GitHub Bot commented on RATIS-272: -------------------------------------- Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r214448422 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogName.java --- @@ -0,0 +1,48 @@ +package org.apache.ratis.logservice.api; + +import static java.util.Objects.requireNonNull; + +import java.util.Objects; + +/** + * Identifier to uniquely identify a {@link LogStream}. + */ +public class LogName { + // It's pretty likely that what uniquely defines a LogStream + // to change over time. We should account for this by making an + // API which can naturally evolve. + private final String name; + + private LogName(String name) { + this.name = requireNonNull(name); + } + + // Implementation detail -- we want uses to use the LogName as identifiable, not to --- End diff -- Nice! Didn't know about these. Happy to add that. > Design ideal API > ---------------- > > Key: RATIS-272 > URL: https://issues.apache.org/jira/browse/RATIS-272 > Project: Ratis > Issue Type: Sub-task > Components: LogService > Reporter: Josh Elser > Priority: Major > > With influence from Apache DistributedLog, Kafka, and BookKeeper, design an > API that balances the ideal notion of what a distribute log system should > look like, but also considers the needs of HBase to replace a WAL. -- This message was sent by Atlassian JIRA (v7.6.3#76005)