[ https://issues.apache.org/jira/browse/RATIS-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640849#comment-16640849 ]
Ted Yu commented on RATIS-274: ------------------------------ {code} + LogStream createLog(LogName name, LogServiceConfiguration config); {code} The single parameter createLog throws exception. Should the above method throw exception as well ? {code} + * @return */ - void removeRecordListener(LogName name, RecordListener listener); + boolean removeRecordListener(LogName name, RecordListener listener); {code} What does the return value represent ? For LogServiceConfiguration#set, Map#put returns: the previous value associated with key, or null if there was no mapping for key It would be good to align the set with Map#put in terms of return value. {code} + try { + log.close(); + close(); + } catch (IOException e) { {code} If log.close throws exception, wouldn't close() call be skipped ? > Read/Write-path of log stream state machine > ------------------------------------------- > > Key: RATIS-274 > URL: https://issues.apache.org/jira/browse/RATIS-274 > Project: Ratis > Issue Type: Sub-task > Components: LogService > Reporter: Josh Elser > Assignee: Vladimir Rodionov > Priority: Major > Attachments: RATIS-274-v1.patch > > > Implement the ability to read/write data to a log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)