[ https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659100#comment-16659100 ]
Tsz Wo Nicholas Sze commented on RATIS-364: ------------------------------------------- [~msingh], thanks for working on this. The approach looks good. Some minor comments: - Rename getConfiguration to readRaftConfiguration, and setRaftConfiguration to writeRaftConfiguration. - We should log a warning when there is an exception in these two methods. - Import RaftProtos.LogEntryProto and then use LogEntryProto in the code. It looks shorter. - Remove raftConf from BaseStateMachine. > Raft should persist configuration entries to meta file > ------------------------------------------------------ > > Key: RATIS-364 > URL: https://issues.apache.org/jira/browse/RATIS-364 > Project: Ratis > Issue Type: Bug > Components: server > Reporter: Mukul Kumar Singh > Assignee: Mukul Kumar Singh > Priority: Major > Attachments: RATIS-364.001.patch > > > The responsibility of storing the raft configuration currently is state > Machine's responsibility. > This jira proposes to add a mechanism for Raft Server to persist the > configuration to its own metafile -- This message was sent by Atlassian JIRA (v7.6.3#76005)