[
https://issues.apache.org/jira/browse/RATIS-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756645#comment-16756645
]
Vladimir Rodionov commented on RATIS-470:
-----------------------------------------
Hey, little bit late ... I posted my suggestion PR review. Copy here:
{quote}
Josh, can we simplify this a little bit? Client gets Raft log ID one every
append, for multi-get calls we can use this LogID (RAFT) as our start log ID to
avoid iterating through all logs, then you can unwind log entries by using new
logic, see above:
int numRecordsInAppend = append.getDataCount();
There is no need to iterate from the very beginning
{quote}
> write(List<ByteBuffer>) not correctly handling all records
> ----------------------------------------------------------
>
> Key: RATIS-470
> URL: https://issues.apache.org/jira/browse/RATIS-470
> Project: Ratis
> Issue Type: Bug
> Components: LogService
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Fix For: 0.4.0
>
>
> Digging into LogServiceReadWriteBase, I'm noticing that the validation clause
> for the data we wrote to the state machine is lacking.
> The test writes 10 "records" into the log, but because we write these in a
> single message to the state machine, we only get one "record" in the Raft log.
> Need to figure out how to take the one client-protobuf message containing N
> "logservice records" but make sure we have N "raft messages" in the log (or
> something equivalent).
> fyi [~chrajeshbab...@gmail.com], [~vrodionov].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
