[
https://issues.apache.org/jira/browse/RATIS-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790066#comment-16790066
]
Hadoop QA commented on RATIS-459:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 22s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.netty.TestRaftWithNetty |
| | ratis.grpc.TestRaftReconfigurationWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-03-11
|
| JIRA Issue | RATIS-459 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12962047/r459_20190311b.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile cc |
| uname | Linux 17176cac87fb 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 5680cf5 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/674/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/674/testReport/ |
| Max. process+thread count | 3332 (vs. ulimit of 5000) |
| modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc U:
. |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/674/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Async requests may become out-of-order in some rare case
> --------------------------------------------------------
>
> Key: RATIS-459
> URL: https://issues.apache.org/jira/browse/RATIS-459
> Project: Ratis
> Issue Type: Improvement
> Components: client, server
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Labels: ozone
> Attachments: r459_20190222.patch, r459_20190227.patch,
> r459_20190228.patch, r459_20190228b.patch, r459_20190308.patch,
> r459_20190311.patch, r459_20190311b.patch
>
>
> With some discussion with [~ljain] (thanks!), the following (highly unlikely)
> hypothetical scenario may lead to the async requests out-of-order.
> # Requests r1-r5 success,
> # Request r6 fails with NotLeader,
> # Request r7 fails with some other IOException
> # r6 is still keeping retrying and a retry of r7 succeeds with s1.
> Below are the suggested fix:
> - In SlidingWindow.Client, resetFirstSeqNum() should, but currently does not,
> clear the request map.
> - If a request is replied with NotLeaderException, it should not be removed
> from the request map until resetFirstSeqNum() above.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
