[ https://issues.apache.org/jira/browse/RATIS-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816257#comment-16816257 ]
Shashikant Banerjee commented on RATIS-518: ------------------------------------------- Thanks [~szetszwo] for the patch. The patch really looks good to me. Some minor comments: 1)RaftClientReply.Java -> Unintended change. 2) Can we rename RequestTypeDependent to RequestTypeDependentRetry? 3) By default, the the retry policy set in RaftClient is retryForeverWithNoSleep , but for requestDependent retry, default is noRetry(). Is there any specific reason for this? Can we have the default behaviour same for both? > Add request specific retry policy support in Ratis > -------------------------------------------------- > > Key: RATIS-518 > URL: https://issues.apache.org/jira/browse/RATIS-518 > Project: Ratis > Issue Type: Improvement > Components: client > Affects Versions: 0.4.0 > Reporter: Shashikant Banerjee > Assignee: Tsz Wo Nicholas Sze > Priority: Major > Attachments: r518_20190409.patch > > > Currently , the retry policy is enforced on a raft client which handles > multiple requests. The idea here is to add support for request specific retry > policy in Raft client. -- This message was sent by Atlassian JIRA (v7.6.3#76005)