[
https://issues.apache.org/jira/browse/RATIS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864500#comment-16864500
]
Hadoop QA commented on RATIS-589:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 11s{color} | {color:orange} root: The patch generated 1 new + 0 unchanged -
2 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 32s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.raftlog.segmented.TestRaftLogReadWrite |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.server.simulation.TestLogAppenderWithSimulatedRpc |
| | ratis.grpc.TestInstallSnapshotWithGrpc |
| | ratis.grpc.TestGroupManagementWithGrpc |
| | ratis.server.raftlog.segmented.TestLogSegment |
| | ratis.netty.TestLogAppenderWithNetty |
| | ratis.netty.TestRaftWithNetty |
| | ratis.server.raftlog.segmented.TestSegmentedRaftLog |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.grpc.TestLogAppenderWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestGroupManagementWithNetty |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.simulation.TestGroupManagementWithSimulatedRpc |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-06-14
|
| JIRA Issue | RATIS-589 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971848/r589_20190614.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux d59620bd76f5 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 3c41936 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/834/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/834/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/834/testReport/ |
| Max. process+thread count | 3434 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/834/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Eliminate buffer copying in SegmentedRaftLogOutputStream
> --------------------------------------------------------
>
> Key: RATIS-589
> URL: https://issues.apache.org/jira/browse/RATIS-589
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Attachments: r589_20190614.patch
>
>
> In SegmentedRaftLogOutputStream.write(LogEntryProto entry), the entry is
> first converted to a byte array and then write to BufferedWriteChannel. In
> BufferedWriteChannel, it copies the byte array to a ByteBuffer. The copying
> should be eliminated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
