[ https://issues.apache.org/jira/browse/RATIS-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874422#comment-16874422 ]
Hadoop QA commented on RATIS-592: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 54s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 10s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 20s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 22s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 41m 29s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.grpc.TestWatchRequestWithGrpc | | | ratis.server.simulation.TestRaftWithSimulatedRpc | | | ratis.netty.TestRaftStateMachineExceptionWithNetty | | | ratis.grpc.TestStateMachineShutdownWithGrpc | | | ratis.grpc.TestRaftStateMachineExceptionWithGrpc | | | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc | | | ratis.grpc.TestRaftWithGrpc | | | ratis.grpc.TestRaftAsyncWithGrpc | | | ratis.server.simulation.TestServerRestartWithSimulatedRpc | | | ratis.netty.TestRaftSnapshotWithNetty | | | ratis.examples.filestore.TestFileStoreWithNetty | | | ratis.examples.filestore.TestFileStoreWithGrpc | | | ratis.logservice.server.TestMetaServer | | | ratis.logservice.TestLogServiceWithNetty | | | ratis.logservice.TestLogServiceWithGrpc | \\ \\ || Subsystem || Report/Notes || | Docker | Client=18.09.5 Server=18.09.5 Image:yetus/ratis:date2019-06-27 | | JIRA Issue | RATIS-592 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12973109/RATIS-592.09.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc | | uname | Linux a2d5fe4f31d7 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / 937f68d | | maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/867/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/867/testReport/ | | Max. process+thread count | 1704 (vs. ulimit of 5000) | | modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/867/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > One node ratis writes fail forever after first NotLeaderException or > LeaderNotReadyException > -------------------------------------------------------------------------------------------- > > Key: RATIS-592 > URL: https://issues.apache.org/jira/browse/RATIS-592 > Project: Ratis > Issue Type: Bug > Components: gRPC > Affects Versions: 0.3.0 > Reporter: Siddharth Wagle > Assignee: Siddharth Wagle > Priority: Critical > Fix For: 0.4.0 > > Attachments: RATIS-592.01.patch, RATIS-592.02.patch, > RATIS-592.03.patch, RATIS-592.04.patch, RATIS-592.05.patch, > RATIS-592.06.patch, RATIS-592.07.patch, RATIS-592.08.patch, RATIS-592.09.patch > > > RATIS-571, modified the GrpcClientProtocolClient to not set the > AsyncStreamObserver reference to null on an exception, however, the ReplyMap > reference is set to null. This results in the client getting an > AlredyClosedException on the stream on a retry for a NotLeader or a > LeadrNotReady exception and never recovers. This is common in a unit test > scenario where a request is sent immediately after the cluster is up. > There is nothing special here about one node Ratis however, the HDDS unit > tests that fail are all one node Ratis and the most probable cause is that > with client retrying a different node each time, increases the chance of > success on a three-node ring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)