[
https://issues.apache.org/jira/browse/RATIS-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886550#comment-16886550
]
Hadoop QA commented on RATIS-610:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 7m
52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} root generated 0 new + 41 unchanged - 1 fixed = 41
total (was 42) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 15s{color} | {color:orange} root: The patch generated 1 new + 18 unchanged -
2 fixed = 19 total (was 20) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 46m 46s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 65m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.grpc.TestInstallSnapshotWithGrpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.server.raftlog.TestRaftLogMetrics |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.TestLogServiceWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/ratis:date2019-07-16 |
| JIRA Issue | RATIS-610 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974879/r610_20190716.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux bac3d600eb50 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3
08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 0d11cd4 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/902/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/902/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/902/testReport/ |
| Max. process+thread count | 1834 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-client ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/902/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add a builder for RaftClientReply
> ---------------------------------
>
> Key: RATIS-610
> URL: https://issues.apache.org/jira/browse/RATIS-610
> Project: Ratis
> Issue Type: Improvement
> Components: API
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Labels: ozone
> Attachments: r610_20190716.patch
>
>
> RaftClientReply has quite a few constructors with many parameters. We should
> employ the builder pattern to build RaftClientReply objects.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
