[ https://issues.apache.org/jira/browse/RATIS-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923020#comment-16923020 ]
Ankit Singhal commented on RATIS-668: ------------------------------------- {quote}-This product uses [https://github.com/mbocek/docker-ganglia/] -Contributed by Michal Bocek +Notice for Dropwizard: -Licensed under the Apache License v2.0 -[https://github.com/mbocek/docker-ganglia/blob/master/LICENSE] -Licensed under the Apache License v2.0 -[https://github.com/mbocek/docker-ganglia/blob/master/LICENSE] {quote} Yes, As per the suggestion we can remove them as they don't provide any NOTICE From apache documentation: ^??If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file.??^ ??^Aside from Apache-licensed dependencies which supply NOTICE files of their own, it is uncommon for a dependency to require additions to NOTICE.??^?? ?? ^However, elements such as the copyright notifications embedded within BSD and MIT licenses need not be duplicated in NOTICE – it suffices to leave those notices in their original locations.??^?? {quote}+Notice for JUnit: + + =================================================================================== + == Notices and attributions required by libraries that the project depends on == + =================================================================================== + The JUnit depends on Java Hamcrest ([http://hamcrest.org/JavaHamcrest/]). {quote} but I don't see a NOTICE file in either [https://github.com/hamcrest/JavaHamcrest] and [https://github.com/junit-team/junit5/] so do we need to include them in our NOTICE? We provide three different NOTICE files, one with source, binary and examples assembly, do we know which file is referred by IPMC? (though we should check all NOTICES to address the concern) > Fix NOTICE file > --------------- > > Key: RATIS-668 > URL: https://issues.apache.org/jira/browse/RATIS-668 > Project: Ratis > Issue Type: Bug > Affects Versions: 0.4.0 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Priority: Blocker > Attachments: RATIS-668.01.patch, RATIS-668.02.patch > > > NOTICE file needs to be updated based on Justin's comments here: > > [https://mail-archives.apache.org/mod_mbox/incubator-general/201908.mbox/%3C8EA21F57-A972-4CBE-AC2F-D3830FE6BDB4%40classsoftware.com%3E] > > -- This message was sent by Atlassian Jira (v8.3.2#803003)