[ https://issues.apache.org/jira/browse/RATIS-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939142#comment-16939142 ]
Lokesh Jain commented on RATIS-678: ----------------------------------- [~swagle] Thanks for updating the patch! The changes look good to me. I think we can move the notifyLeaderChanged call in the newLeader!=null block. We can also add a check that newLeader!=leaderId before making the call. +1 o.w. > Notify Leader does not provide raft group id > -------------------------------------------- > > Key: RATIS-678 > URL: https://issues.apache.org/jira/browse/RATIS-678 > Project: Ratis > Issue Type: Improvement > Components: raft-group > Affects Versions: 0.4.0 > Reporter: Siddharth Wagle > Assignee: Siddharth Wagle > Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-678.01.patch, RATIS-678.02.patch > > > org.apache.ratis.statemachine.StateMachine#notifyLeader > does not provide the group id for which leader election is complete. -- This message was sent by Atlassian Jira (v8.3.4#803005)