[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941384#comment-16941384 ]
Hadoop QA commented on RATIS-693: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 36s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 35m 34s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 44m 33s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.logservice.TestLogServiceWithNetty | | | ratis.examples.filestore.TestFileStoreWithNetty | | | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc | | | ratis.grpc.TestServerRestartWithGrpc | | | ratis.grpc.TestInstallSnapshotNotificationWithGrpc | | | ratis.grpc.TestRaftSnapshotWithGrpc | | | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc | | | ratis.grpc.TestWatchRequestWithGrpc | | | ratis.netty.TestRaftSnapshotWithNetty | | | ratis.server.raftlog.TestRaftLogMetrics | | | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc | | | ratis.grpc.TestRaftStateMachineExceptionWithGrpc | | | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.2 Server=19.03.2 Image:yetus/ratis:date2019-09-30 | | JIRA Issue | RATIS-693 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12981832/RATIS-693.01.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux eddde1b175b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / fb56bcb | | maven | version: Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) | | Default Java | 1.8.0_222 | | whitespace | https://builds.apache.org/job/PreCommit-RATIS-Build/1011/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/1011/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/1011/testReport/ | | Max. process+thread count | 1431 (vs. ulimit of 5000) | | modules | C: ratis-server U: ratis-server | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/1011/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Combine notifyLeader and notifyLeaderChanged calls on StateMachine > ------------------------------------------------------------------ > > Key: RATIS-693 > URL: https://issues.apache.org/jira/browse/RATIS-693 > Project: Ratis > Issue Type: Improvement > Components: raft-group, server > Affects Versions: 0.5.0 > Reporter: Siddharth Wagle > Assignee: Siddharth Wagle > Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-693.01.patch > > > RATIS-678 introcuded _notifyLeaderChanged_ API on the StateMachine interface > which will be called to notify the statemachine when the leaderId changes on > leader as well as the follower. > Downstream services like Ozone utilize this functionality to decide when the > Raft group is ready to accept writes and do open the write pipeline. > Purpose of this jira is to combine notifyLeader and notifyLeaderChanged into > a single API. -- This message was sent by Atlassian Jira (v8.3.4#803005)