[ https://issues.apache.org/jira/browse/RATIS-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946294#comment-16946294 ]
Josh Elser commented on RATIS-672: ---------------------------------- Thanks, Clay! Your fix certainly makes sense. Just realized why QA didn't catch this last time. Yetus does the following: * Builds the base image * Builds a new image on top of that one with the patch changes * Runs the maven build We never actually test building the new Docker image. I'm too Yetus dumb to know if this is something we're not doing correct, or if it's a limitation of Yetus itself? I think HBase has something around this, but I'm not sure what it is off the top of my head. Maybe [~psomogyi] or [~busbey] know if HBase has special logic that might help us test when our QA docker image changes in the patch being submitted? > Vagrant and Docker Test 404 on Maven Download > --------------------------------------------- > > Key: RATIS-672 > URL: https://issues.apache.org/jira/browse/RATIS-672 > Project: Ratis > Issue Type: Improvement > Components: test > Reporter: Clay B. > Assignee: Clay B. > Priority: Trivial > Fix For: 0.5.0 > > Attachments: 0001-RATIS-672.-Vagrant-test-s-Maven-404-s.patch, > RATIS-672.001.patch > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Vagrant tests are > [pointing|https://github.com/apache/incubator-ratis/blob/35838f032a4096d78843130fa1435bcddf5ce961/dev-support/vagrant/Vagrantfile#L92] > to a specific mirror and a URL which broke with the new Maven 3.6.x release. > We should point to an {{archive.apache.org}} URL if I understand correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005)