[
https://issues.apache.org/jira/browse/RATIS-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956288#comment-16956288
]
Josh Elser commented on RATIS-680:
----------------------------------
Thanks for the new patch, Anu. Sorry for the delay on reviewing it.
Including the license header for PureJavaCrc32.java, bulk_crc32_x86.c,
bulk_crc32.c is unnecessary in the LICENSE file. The LICENSE file already
covers all Apache-Licensed code in Ratis. We only care about code that is being
redistributed under some other license.
The section you added for the 2-clause BSD (the "For the lookup tables in
PureJavaCRC32C.java" part) licensed portion is great. The phrasing there is
specific enough to tell us what part of that file is BSD licensed.
The section for "For portions of the native implementation of slicing-by-8 CRC
calculation" is still insufficient – you've not addressed Justin M's concern.
The text which says "BSD-style license" is not sufficient. You must copy/paste
the exact BSD variant from the LICENSE file included in the codebase this code
was copied from into Ratis' LICENSE file. Specifically, this text:
{noformat}
Copyright (c) 2008,2009,2010 Massachusetts Institute of Technology.
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
* Neither the name of the Massachusetts Institute of Technology nor
the names of its contributors may be used to endorse or promote
products derived from this software without specific prior written
permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
{noformat}
must be included in the Ratis' LICENSE file, in place of the paragraph starting
with "Copyright 2008,2009,2010 Massachusetts Institute of Technology.".
LMK if that's clear (or not).
> Fix LICENSE file issues
> -----------------------
>
> Key: RATIS-680
> URL: https://issues.apache.org/jira/browse/RATIS-680
> Project: Ratis
> Issue Type: Bug
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Priority: Blocker
> Attachments: RATIS-680.01.patch, RATIS-680.02.patch
>
>
> Fix Ratis LICENSE file issues raised by Justin here:
> https://mail-archives.apache.org/mod_mbox/incubator-general/201909.mbox/%3C573A4F4D-8303-418D-8133-03AAC8085708%40me.com%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
