[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961508#comment-16961508 ]
Tsz-wo Sze commented on RATIS-457: ---------------------------------- [~ljain], thanks for the update. The patch looks good. Just one minor comment: - In RaftServerImpl, it used both 0 and -1 when the matchIndex is missing. They should use the same value. Let's use RaftLog.INVALID_LOG_INDEX (=-1)? > gRPC timed out append entry reply should update follower match index > -------------------------------------------------------------------- > > Key: RATIS-457 > URL: https://issues.apache.org/jira/browse/RATIS-457 > Project: Ratis > Issue Type: Improvement > Components: gRPC > Reporter: Lokesh Jain > Assignee: Lokesh Jain > Priority: Major > Labels: ozone > Attachments: RATIS-457.001.patch, RATIS-457.002.patch, > RATIS-457.003.patch, RATIS-457.004.patch, RATIS-457.005.patch > > > Currently all the timed out append entry replies are ignored by the leader. > These replies have information like match index which can be updated by > leader. -- This message was sent by Atlassian Jira (v8.3.4#803005)