[
https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978214#comment-16978214
]
Lokesh Jain edited comment on RATIS-729 at 11/20/19 8:55 AM:
-------------------------------------------------------------
| Do you mean non-null?
Yes. I meant non-null.
| we may add a precondition as follow
Yes, I agree we can add a precondition like that with an error message. But
this can lead to server failure. Should we rather add a log message in
ClientProtoUtils#toRaftClientReplyProto with a precondition in the client? I
looked at the code there is no instance where success flag is false and
exception field is null for RaftClientReply.
was (Author: ljain):
| Do you mean non-null?
Yes. I meant non-null.
| we may add a precondition as follow
Yes, I agree we can add a precondition like that with an error message. But
this can lead to server failure. Should we rather add a log message in
ClientProtoUtils#toRaftClientReplyProto with a precondition in the client? I
looked at the code there is no instance where success flag is false and
exception field is null for RaftClientReply.
> ClientProtoUtils#toRaftClientReplyProto should consider all RaftException
> types
> -------------------------------------------------------------------------------
>
> Key: RATIS-729
> URL: https://issues.apache.org/jira/browse/RATIS-729
> Project: Ratis
> Issue Type: Bug
> Components: client
> Reporter: Lokesh Jain
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: RATIS-729.001.patch
>
>
> In one of the runs it is seen that client receives RaftClientReply with
> exception as null and success flag as false. This happens because currently
> ClientProtoUtils#toRaftClientReplyProto only considers a few RaftException
> types while creating a RaftClientReplyProto. We should also add handling for
> other exception types.Similar changes will be required in
> ClientProtoUtils#toRaftClientReply.
> We will also need to add handling for these exceptions in the client code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
