[ https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982236#comment-16982236 ]
Lokesh Jain commented on RATIS-729: ----------------------------------- {code:java} + if (r.getException() != null) { {code} [~hanishakoneru] Thanks for updating the patch! r.getException() == null is also an error situation for us when reply.getException() != null. Also can we log the exception stack trace when there is a mismatch? > ClientProtoUtils#toRaftClientReplyProto should consider all RaftException > types > ------------------------------------------------------------------------------- > > Key: RATIS-729 > URL: https://issues.apache.org/jira/browse/RATIS-729 > Project: Ratis > Issue Type: Bug > Components: client > Reporter: Lokesh Jain > Assignee: Hanisha Koneru > Priority: Major > Attachments: RATIS-729.001.patch, RATIS-729.002.patch, > RATIS-729.003.patch, RATIS-729.004.patch > > > In one of the runs it is seen that client receives RaftClientReply with > exception as null and success flag as false. This happens because currently > ClientProtoUtils#toRaftClientReplyProto only considers a few RaftException > types while creating a RaftClientReplyProto. We should also add handling for > other exception types.Similar changes will be required in > ClientProtoUtils#toRaftClientReply. > We will also need to add handling for these exceptions in the client code. -- This message was sent by Atlassian Jira (v8.3.4#803005)