[
https://issues.apache.org/jira/browse/RATIS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987907#comment-16987907
]
Hadoop QA commented on RATIS-458:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 11s{color} | {color:orange} root: The patch generated 1 new + 13 unchanged -
1 fixed = 14 total (was 14) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 28s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
18s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 1s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.grpc.TestLogAppenderWithGrpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2019-12-04 |
| JIRA Issue | RATIS-458 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12987475/RATIS-458.007.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 47ca2dd2d0ef 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1
05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 22ceab2 |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/1177/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1177/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1177/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-RATIS-Build/1177/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 1400 (vs. ulimit of 5000) |
| modules | C: ratis-server ratis-grpc ratis-test U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1177/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> GrpcLogAppender#shouldWait should wait on pending log entries to follower
> -------------------------------------------------------------------------
>
> Key: RATIS-458
> URL: https://issues.apache.org/jira/browse/RATIS-458
> Project: Ratis
> Issue Type: Improvement
> Components: gRPC
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Labels: ozone
> Attachments: RATIS-458.001.patch, RATIS-458.002.patch,
> RATIS-458.003.patch, RATIS-458.004.patch, RATIS-458.005.patch,
> RATIS-458.006.patch, RATIS-458.007.patch
>
>
> In GrpcLogAppender when an append entry times out we remove the entry from
> the pendingRequests. This decreases the size of pendingRequests which affects
> the logic in GrpcLogAppender#shouldWait. Further we also consider heartbeats
> in shouldWait because heartbeats are tracked in pendingRequests. It should
> actually wait on the number of log entries which are appended to follower but
> have not yet been processed by it.
> GrpcConfigKeys.Server.leaderOutstandingAppendsMax should also be a fraction
> of RaftServerConfigKeys.Log.queueSize. This brings flow control for leader's
> append entries to follower because then number of outstanding append entries
> in leader would be limited by maximum number of operations in raft log worker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
