[ https://issues.apache.org/jira/browse/RATIS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026040#comment-17026040 ]
Shashikant Banerjee commented on RATIS-683: ------------------------------------------- Thanks [~avijayan] for working on this. The patch looks good to me. Please have a look at the test failure for testStateMachineMetrics although it does not look related along with the checkstyle issues. > Test and cleanup Ratis Metrics work > ----------------------------------- > > Key: RATIS-683 > URL: https://issues.apache.org/jira/browse/RATIS-683 > Project: Ratis > Issue Type: Sub-task > Reporter: Lokesh Jain > Assignee: Aravindan Vijayan > Priority: Major > Attachments: RATIS-683-000.patch, RATIS-683-001.patch > > > Since the Ratis metrics work is going on in parallel from multiple folks, it > will be a good idea to have a final sanity check and cleanup tasks to bring > the task to closure. These are the tasks aimed in this JIRA. > * Organize RatisMetrics and RatisMetricNames into a single class > (It would be good to organize RatisMetrics and RatisMetricNames into a single > class. The metrics can be organized like RaftServerConfigKeys and > RaftClientConfigKeys so that metrics corresponding to a particular component > like Log, Appender can be tracked in a sub class) > * Investigate whether we can move the groupId and followerId in metric names > to attributes. This will make aggregation from a metrics system easier. > * Deploy a cluster and do sanity check of all metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)