[ https://issues.apache.org/jira/browse/RATIS-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031188#comment-17031188 ]
Hadoop QA commented on RATIS-810: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 41s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 17s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 5s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 46m 31s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 56m 5s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.logservice.TestLogServiceWithNetty | | | ratis.logservice.server.TestMetaServer | | | ratis.grpc.TestServerRestartWithGrpc | | | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc | | | ratis.netty.TestRaftStateMachineExceptionWithNetty | | | ratis.netty.TestRaftReconfigurationWithNetty | | | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc | | | ratis.server.raftlog.TestRaftLogMetrics | | | ratis.server.simulation.TestServerRestartWithSimulatedRpc | | | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc | | | ratis.netty.TestRaftSnapshotWithNetty | | | ratis.grpc.TestRaftSnapshotWithGrpc | | | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc | | | ratis.grpc.TestWatchRequestWithGrpc | | | ratis.netty.TestRaftWithNetty | | | ratis.server.simulation.TestRaftWithSimulatedRpc | | | ratis.examples.filestore.TestFileStoreWithNetty | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-02-06 | | JIRA Issue | RATIS-810 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12992732/RATIS-810.00.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux a253544e01d8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / b5528af | | maven | version: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/1237/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/1237/testReport/ | | Max. process+thread count | 1487 (vs. ulimit of 5000) | | modules | C: ratis-server ratis-examples U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/1237/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Add metrics for SegmentedRaftLogWorker#WriteLog > ----------------------------------------------- > > Key: RATIS-810 > URL: https://issues.apache.org/jira/browse/RATIS-810 > Project: Ratis > Issue Type: Improvement > Components: server > Reporter: Lokesh Jain > Assignee: Bharat Viswanadham > Priority: Major > Attachments: RATIS-810.00.patch > > > WriteLog is an expensive operation and we should track its execution time in > SegmentedRaftLogWorker. We should also track the time we wait on the > stateMachineFuture. > -- This message was sent by Atlassian Jira (v8.3.4#803005)