[ 
https://issues.apache.org/jira/browse/RATIS-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087864#comment-17087864
 ] 

Shashikant Banerjee commented on RATIS-853:
-------------------------------------------

Thanks [~ljain] for working on this. The patch looks good. Few minor comments 
inline:

1) Can we move getEffectiveRetryPolicy function from RetryPolicies.Java to some 
utility class like clientImplUtils?

2) As we go ahead, i am hoping retryForeverForNoSleep will not be used for any 
exception in any case right? Can we add a comment or TODO stating the same? 

> Unordered Client request should not sleep when NotLeaderException provides 
> leader information
> ---------------------------------------------------------------------------------------------
>
>                 Key: RATIS-853
>                 URL: https://issues.apache.org/jira/browse/RATIS-853
>             Project: Ratis
>          Issue Type: Bug
>          Components: client
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: RATIS-853.001.patch
>
>
> When NotLeaderException provides leader information, the client request 
> should be retried immediately on the suggested leader. Currently Unordered 
> requests in raft client use the default policy to determine sleep time and 
> thus may sleep even if NotLeaderException provides leader information.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to