[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088980#comment-17088980 ]
Hanisha Koneru edited comment on RATIS-850 at 4/21/20, 10:37 PM: ----------------------------------------------------------------- Thank you [~ljain] and [~msingh] for the reviews. bq. We can purge the entries which have not yet been included in the snapshot. I think this can cause bugs later on. StateMachine should strictly have no dependencies on these log entries? Are you saying we should only purge upto the snapshotIndex? I am okay with that. I kept it this way as the previous behaviour is to purge upto the highest commit index between all peers. Let me know what you think. Thanks. was (Author: hanishakoneru): Thank you [~ljain] and [~msingh] for the reviews. {quote}bq. We can purge the entries which have not yet been included in the snapshot. I think this can cause bugs later on. StateMachine should strictly have no dependencies on these log entries? {quote} Are you saying we should only purge upto the snapshotIndex? I am okay with that. I kept it this way as the previous behaviour is to purge upto the highest commit index between all peers. Let me know what you think. Thanks. > Allow log purge up to snapshot index > ------------------------------------ > > Key: RATIS-850 > URL: https://issues.apache.org/jira/browse/RATIS-850 > Project: Ratis > Issue Type: Improvement > Reporter: Hanisha Koneru > Assignee: Hanisha Koneru > Priority: Major > Attachments: RATIS-850.001.patch, RATIS-850.002.patch > > > Ratis logs are purged only up to the least commit index on all the peers. But > if one peer is down, it stop log purging on all the peers. If the Ratis > server takes snapshots, then we can purge logs up to the snapshot index even > if some peer has not committed up to that index. When the peer rejoins the > ring, instead of ratis logs, it can get the snapshot to catch up. -- This message was sent by Atlassian Jira (v8.3.4#803005)