[
https://issues.apache.org/jira/browse/ROCKETMQ-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233984#comment-16233984
]
ASF GitHub Bot commented on ROCKETMQ-306:
-----------------------------------------
aCoder2013 closed pull request #187: [ROCKETMQ-306] Improve thread name
URL: https://github.com/apache/rocketmq/pull/187
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index db9e5124..6e63092e 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -31,6 +31,7 @@
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
+import org.apache.rocketmq.common.ThreadFactoryImpl;
import org.apache.rocketmq.common.message.Message;
import org.apache.rocketmq.common.message.MessageClientIDSetter;
import org.apache.rocketmq.common.message.MessageExt;
@@ -121,7 +122,7 @@ public void initTransactionEnv() {
producer.getCheckThreadPoolMaxSize(),
1000 * 60,
TimeUnit.MILLISECONDS,
- this.checkRequestQueue);
+ this.checkRequestQueue,new
ThreadFactoryImpl("CheckRequestThread_"));
}
public void destroyTransactionEnv() {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Specify thread's name of DefaultMQProducerImpl's checkExecutor
> --------------------------------------------------------------
>
> Key: ROCKETMQ-306
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-306
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Affects Versions: 4.1.0-incubating
> Reporter: acoder2014
> Assignee: Xiaorui Wang
> Priority: Critical
>
> Current the way of initializing checkExecutor didn't specify a threadFactory
> with provided a meaningful thread name which is very helpful to trace the
> error information,so we better assign a name of this thread pool.
> {code:java}
> this.checkExecutor = new ThreadPoolExecutor(
> producer.getCheckThreadPoolMinSize(),
> producer.getCheckThreadPoolMaxSize(),
> 1000 * 60,
> TimeUnit.MILLISECONDS,
> this.checkRequestQueue);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
