[
https://issues.apache.org/jira/browse/ROCKETMQ-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235248#comment-16235248
]
ASF GitHub Bot commented on ROCKETMQ-270:
-----------------------------------------
zhouxinyu opened a new pull request #189: [ROCKETMQ-270] Move flush position
forward to first MappedFile whose start offset is non-zero
URL: https://github.com/apache/rocketmq/pull/189
## What is the purpose of the change
To resolve the issue
[ROCKETMQ-270](https://issues.apache.org/jira/browse/ROCKETMQ-270).
Slave Broker can't flush data to disk normally if the master broker has been
cleaned commit log.
## Brief changelog
When the flush position is zero and the first MappedFile's start offset is
non-zero, move it forward to the first MappedFile's start offset. Otherwise,
slave broker can't flush data to disk normally.
## Verifying this change
1. Start master broker, and write lots of messages until broker starts
cleaning commit log.
2. When the first commit log file isn't 00000000000000, start slave broker.
3. Slave broker now can flush data normally.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
- [X] Format the pull request title like `[ROCKETMQ-XXX] Fix
UnknownException when host config not exist`. Each commit in the pull request
should have a meaningful subject line and body.
- [X] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [X] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add integration-test in
[test module](https://github.com/apache/rocketmq/tree/master/test).
- [X] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [X] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Slave Broker can't start normally if master broker has been cleaned commit log
> ------------------------------------------------------------------------------
>
> Key: ROCKETMQ-270
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-270
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Reporter: yukon
> Assignee: yukon
> Priority: Major
> Fix For: 4.2.0
>
>
> How to reproduce this bug?
> 1. Start master broker, and write lots of messages until broker starts
> cleaning commit log.
> 2. When the first commit log file isn't 00000000000000, start slave broker.
> In current state, slave broker will pull messages from master broker, but the
> first message's offset isn't zero, and isn't equal to commit offset, so slave
> broker could't do right flush.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
