[
https://issues.apache.org/jira/browse/ROCKETMQ-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272671#comment-16272671
]
ASF GitHub Bot commented on ROCKETMQ-321:
-----------------------------------------
zhouxinyu commented on a change in pull request #198: [ROCKETMQ-321] Fix
deleting files in the middle
URL: https://github.com/apache/rocketmq/pull/198#discussion_r154075283
##########
File path: store/src/main/java/org/apache/rocketmq/store/MappedFile.java
##########
@@ -570,6 +570,11 @@ public void munlock() {
log.info("munlock {} {} {} ret = {} time consuming = {}", address,
this.fileName, this.fileSize, ret, System.currentTimeMillis() - beginTime);
}
+ //testable
+ File getFile() {
+ return this.file;
Review comment:
LGTM, but no need to return this file to test code, you could structure the
File object directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid deleting mapped files in the middle
> -----------------------------------------
>
> Key: ROCKETMQ-321
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-321
> Project: Apache RocketMQ
> Issue Type: Bug
> Affects Versions: 4.1.0-incubating
> Reporter: dongeforever
> Assignee: dongeforever
> Fix For: 4.2.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
