[ 
https://issues.apache.org/jira/browse/ROCKETMQ-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274306#comment-16274306
 ] 

ASF GitHub Bot commented on ROCKETMQ-292:
-----------------------------------------

zhouxinyu closed pull request #169: [ROCKETMQ-292]Delete system.exit in 
MQAdminStartup
URL: https://github.com/apache/rocketmq/pull/169
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java 
b/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java
index 6398291a..60ca59e8 100644
--- a/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java
+++ b/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java
@@ -117,7 +117,6 @@ public static void main0(String[] args, RPCHook rpcHook) {
                             ServerUtil.parseCmdLine("mqadmin " + 
cmd.commandName(), subargs, cmd.buildCommandlineOptions(options),
                                 new PosixParser());
                         if (null == commandLine) {
-                            System.exit(-1);
                             return;
                         }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Delete system.exit in MQAdminStartup
> ------------------------------------
>
>                 Key: ROCKETMQ-292
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-292
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-tools
>    Affects Versions: 4.1.0-incubating
>            Reporter: lindzh
>            Assignee: yukon
>             Fix For: 4.2.0
>
>
> When using MQAdminStartup in a java process,some args problem may cause 
> MQAdminStartup to call system.ext and this lead to main java process 
> shutdown. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to