[
https://issues.apache.org/jira/browse/ROCKETMQ-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279826#comment-16279826
]
ASF GitHub Bot commented on ROCKETMQ-324:
-----------------------------------------
zhouxinyu opened a new pull request #201: [ROCKETMQ-324] Expose an interface
for client to specify the async call back executor
URL: https://github.com/apache/rocketmq/pull/201
## What is the purpose of the change
Currently, the async call back will be executed in a public executor which
is mainly used in CHECK_TRANSACTION_STATE, NOTIFY_CONSUMER_IDS_CHANGED,
CONSUME_MESSAGE_DIRECTLY, etc. More details please refer to MQClientAPIImpl.
Should expose an interface for the client to specify the independent call
back executor.
## Brief changelog
Add an interface `setCallbackExecutor` in RemotingClient.java and
DefaultMQProducer.java
## Verifying this change
Run the unit tests to verify.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ROCKETMQ-XXX] Fix
UnknownException when host config not exist`. Each commit in the pull request
should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add integration-test in
[test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [x] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Expose an interface for client to specify the async call back executor
> ----------------------------------------------------------------------
>
> Key: ROCKETMQ-324
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-324
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Reporter: yukon
> Assignee: yukon
> Fix For: 4.2.0
>
>
> Currently, the async call back will be executed in a public executor which is
> mainly used in CHECK_TRANSACTION_STATE, NOTIFY_CONSUMER_IDS_CHANGED,
> CONSUME_MESSAGE_DIRECTLY, etc. More details please refer to MQClientAPIImpl.
> Should expose an interface for client to specify the independent call back
> executor.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
