[
https://issues.apache.org/jira/browse/ROCKETMQ-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291964#comment-16291964
]
ASF GitHub Bot commented on ROCKETMQ-290:
-----------------------------------------
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in
WaitNotifyObject#waitingThreadTable
URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059
@zhouxinyu Unit tests added, please check these out.
This bug actually has major impact on the performance
if this leaks happens repeatedly and brokerRole is set to SYNC_MASTER.
org.apache.rocketmq.store.ha.WaitNotifyObject#wakeupAll is called in
org.apache.rocketmq.store.CommitLog#handleHA when broker is process a
SendMessageRequest. WaitNotifyObject#wakeupAll would iterate through all values
in waitingThreadTable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Memory leaks in
> org.apache.rocketmq.store.ha.WaitNotifyObject#waitingThreadTable
> --------------------------------------------------------------------------------
>
> Key: ROCKETMQ-290
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-290
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-store
> Affects Versions: 4.1.0-incubating
> Reporter: Jas0n918
> Assignee: yukon
> Priority: Critical
>
> There are only add-element operations for waitingThreadTable in Class
> org.apache.rocketmq.store.ha.WaitNotifyObject.
> Each time a new thread calls Method WaitNotifyObject#allWaitForRunning,
> waitingThreadTable get new element.
> This leak actually happens in Master Broker when Slave reconnect to the
> Master, a new HAConnection is created, and WaitNotifyObject#allWaitForRunning
> will be called in LogHAConnection.WriteSocketService#run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
