[ 
https://issues.apache.org/jira/browse/ROCKETMQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831310#comment-15831310
 ] 

ASF GitHub Bot commented on ROCKETMQ-44:
----------------------------------------

Github user wu-sheng commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/38#discussion_r97021619
  
    --- Diff: 
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
    @@ -1278,7 +1282,8 @@ public void doDispatch(DispatchRequest req) {
             }
         }
     
    -    public void putMessagePositionInfo(String topic, int queueId, long 
offset, int size, long tagsCode, long storeTimestamp,
    +    public void putMessagePositionInfo(String topic, int queueId, long 
offset, int size, long tagsCode,
    +        long storeTimestamp,
    --- End diff --
    
    @vongosling , I am not sure what in checkstyle trigger this. And what is 
**UT**? Sorry, no clue. 😝


> Duplicated codes in DefaultMessageStore.getEarliestMessageTime and 
> DefaultMessageStore.getMessageStoreTimeStamp
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-44
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-44
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Wu Sheng
>            Assignee: vongosling
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to