[jira] [Commented] (ROCKETMQ-70) Duplicate methods in NettyRemotingClient

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833405#comment-15833405
 ] 

ASF GitHub Bot commented on ROCKETMQ-70:
----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/48
  
    
    [![Coverage 
Status](https://coveralls.io/builds/9785769/badge)](https://coveralls.io/builds/9785769)
    
    Coverage decreased (-0.06%) to 26.245% when pulling 
**e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman:ROCKETMQ-70** into 
**881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master**.



> Duplicate methods in NettyRemotingClient
> ----------------------------------------
>
>                 Key: ROCKETMQ-70
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-70
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-remoting
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>            Priority: Trivial
>
> {{NettyRemotingClient}} contains two methods doing the same thing as 
> overridden {{getRPCHook}}  and {{getNameServerAddressList}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)