[ https://issues.apache.org/jira/browse/ROCKETMQ-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
yukon reopened ROCKETMQ-59: --------------------------- > Charset misusage in RocketMQSerializable > ---------------------------------------- > > Key: ROCKETMQ-59 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-59 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-remoting > Affects Versions: 4.1.0-incubating > Reporter: Kailai Shao > Assignee: vongosling > Priority: Minor > Fix For: 4.0.0-incubating > > > When writing unit tests for rocketmq-remoting, I found that > {{RocketMQSerializable}} misused the charset for {{RemotingSerializable}}. > Go into details. The class {{RemotingCommand}} has two formats to serialize > its header: JSON format (source code {{RemotingSerializable.java}}) and > ROCKETMQ (source code {{RocketMQSerializable.java}}) format, respectively. > Both formats have their own encode method, decode method and charset. But > methods in {{RocketMQSerializable.java}} use the charset for > {{RemotingSerializable.java}}. > Although two charsets are both UTF-8 thus no problem occurs so far, but it's > better to modify to make the code commonsensible :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)